Skip to content

Possible typo in container URL for Medaka#176

Merged
nschan merged 2 commits intonf-core:devfrom
TomHarrop:patch-1
Sep 18, 2025
Merged

Possible typo in container URL for Medaka#176
nschan merged 2 commits intonf-core:devfrom
TomHarrop:patch-1

Conversation

@TomHarrop
Copy link
Copy Markdown

@TomHarrop TomHarrop commented Sep 18, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/genomeassembler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 18, 2025

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @TomHarrop,

It looks like this pull-request is has been made against the TomHarrop/genomeassembler master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the TomHarrop/genomeassembler dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@TomHarrop TomHarrop changed the base branch from master to dev September 18, 2025 01:01
@nschan nschan merged commit aaa8ae6 into nf-core:dev Sep 18, 2025
52 of 57 checks passed
@nschan
Copy link
Copy Markdown
Collaborator

nschan commented Sep 18, 2025

Thanks a lot for noticing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nschan nschan nschan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomHarrop @nschan